Basic Frontend

Community feedback

• 

  Boluwatife Bonaventure•550

  @BoyutifePosted over 1 year ago

  Hi Newman-afk👋. Congratulations on successfully completing the challenge! 🎉

  I have some additional suggestions for your code that I believe will be of great interest to you.

  HTML 🏷️:

  • Ensure headings are in a logical order. For example, check that all headings are marked with h1 through h6 elements and that these are ordered hierarchically. For example, the heading level following an h1 element should be an h2 element, not an h3 element. Finally, don't use heading mark up on text that isn't actually a heading.

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage. To address this issue, you can review the HTML code of the webpage and add appropriate landmarks where necessary. Some common landmarks that you may want to consider including are: <header> <main> <section> <aside> instead of multiple <div> <span>

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  newman-afk•220

  @newman-afkPosted over 1 year ago

  @Boyutife Thank you! I use h1~h6 randomly because I don't know the actual size of the design, but yeah, you are right. and the div div div……， a lot of teachers from youtube told me the same, but it's like naming stuff, too easy to nonsense. have a good day!

  1