Skip to content
Submitted about 1 year ago

base-apparel-coming-soon-master

AhmarIftikhar123•660
@AhmarIftikhar123
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Base Apparel coming soon page
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Please! gave feedback how to make a responsive web page.

Community feedback

  • Abhishek Sahu•200
    @Abhishek-Sahu532Posted about 1 year ago

    Hello there 👋. Congratulations on going to completing the challenge! 🎉

    The desktop layout still not looks completed. You need to spend more time to capturing the actual pixels to get the look of the page in the design folder.

    My feedback is for you to work on the CSS part, Some days earlier I completed the project, so you can check the solution to get an idea and write it on your own.

    I hope you find this helpful 😄 Above all, the solution you submitted is great!

    Happy coding!

    1
  • IryDev•1,580
    @IryDevPosted about 1 year ago

    Hey @AhmarIftikhar123, you did a good job on this challenge 😀

    I have some advice to improve your solution :

    • The mobile layout seems good but I think you have to rework the desktop layout don't forget that the goal isn't to reproduce the design down to the pixel
    • The property background-size: contain will be applied only to the background element. If you want your image to cover all the space use object-fit: cover
    • Your solution doesn't use semantic HTML that can improve accessibility on your website
    • Wrap the whole main content of your page in the <main> tag

    HTML

    <body>
<main>
The main content of your website
</main>
</body>

    CSS:

    img{
object-fit: cover;
}

    I hope you'll find this helpful full and above all, your solution is great

    0
    AhmarIftikhar123•660
    @AhmarIftikhar123Posted about 1 year ago

    Thanks you very much very value-able advice.

    0
    IryDev•1,580
    @IryDevPosted about 1 year ago

    @AhmarIftikhar123 No problem, I'm glad you found this helpful😄

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord