Base apparel coming soon with SASS and JS

Community feedback

• 

  Emmanuel Akwaboah•220

  @Cyrus-Akwaboah-EmmanuelPosted over 3 years ago

  Good work except that its height is not 100% fixed. Apart from that everything else is ok. The color corresponds to the color of her shirt and her skin(sort of) 👌

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @Cyrus-Akwaboah-Emmanuel Thank you for pointing that out! I made the background pattern fixed now. ^^

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Rael! 👋

  Congratulations on finishing another challenge! Again, good job! Please don't be too hard on yourself, your solution is very close to design. These backgrounds are often pain in the.. I know from own experience, especially when they have such colors like in this challenge. Small tips:

  • Since your .wrapper__logo image is decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers. The same goes for .img-desktop.
  • Add border: none; to your .wrapper__btn to get rid of this 1px white border.
  • " We're coming soon" is your title, you want that to be your heading <h1-h6> element. Wrap the text that you want to be bold with <span> but within this h1 element. To make this wrapped effect you can use max-width property on that element.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @tediko Thank you for the suggestions and kind words! ^^

  I've already made the tweaks as per your suggestions! I probably should have simply used a div with background-image on those images, now that I think about it.

  Thanks again for the advice! ^^

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Yes the light colors on this challenge make it extra annoying I agree but you should look at your mobile to desktop transition around 1000px you have some text issues that you need to probably tweak a little bit

  1

  ---

  

  Rael•270

  @RaelianPosted over 3 years ago

  @palgramming Thank you for pointing it out! I actually left it like that on purpose but after taking another look it did look kinda... fugly and not fitting so I tweaked the text to have the same width as the image. It should look more eye pleasing now.

  Thank you once more! ^^

  0

  

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  @Raelian No problem glad I could help. People keep talking responsive but I think they key word should be consistent experience across screen width. Thing do not need to endlessly scale up and down. Controlling the items so they look good across all widths seems more important

  1