Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Base Apparel Coming Soon, pure HTML, CSS & JS

VerDanT 280

@NVergil

Desktop design screenshot for the Base Apparel coming soon page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Project built with HTML, CSS and Vanilla JS 💻

Any feedback will be appreciated 🤓

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.
  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

Example:

<img src="images/decorative.svg" alt="">

<img class="icon-error" src="./images/icon-error.svg" alt="icon-error">
  👇
<img class="icon-error" src="./images/icon-error.svg" alt="">

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@ShivangamSoni

Posted

Nice Job

Few feedbacks:

  • There's too much layout shift on the Desktop when a Form error occurs. It's because the error para is not having any height. You can fix this issue by setting a min-height
  • After showing the error, you are clearing the input, which is not a desirable behavior. The user usually wants to try to fix the issue by updating the already inputted data.

Marked as helpful

1

VerDanT 280

@NVergil

Posted

@ShivangamSoni

TYSM!! I think it is now fixed 😀

1

@ShivangamSoni

Posted

@NVergil Nice Work

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord