Base Apparel Coming Soon, pure HTML, CSS & JS

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img class="icon-error" src="./images/icon-error.svg" alt="icon-error">
    👇
  <img class="icon-error" src="./images/icon-error.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Shivangam Soni•1,030

  @ShivangamSoniPosted over 1 year ago

  Nice Job

  Few feedbacks:

  • There's too much layout shift on the Desktop when a Form error occurs. It's because the error para is not having any height. You can fix this issue by setting a min-height
  • After showing the error, you are clearing the input, which is not a desirable behavior. The user usually wants to try to fix the issue by updating the already inputted data.

  Marked as helpful

  1

  ---

  

  VerDanT•280

  @NVergilPosted over 1 year ago

  @ShivangamSoni

  TYSM!! I think it is now fixed 😀

  1

  

  Shivangam Soni•1,030

  @ShivangamSoniPosted over 1 year ago

  @NVergil Nice Work

  0