Base Apparel Challenge

Community feedback

• 

  Aakash Verma•6,710

  @skyv26Posted almost 3 years ago

  Hi! Lesley, my friend, you did really good with all your efforts but have some issues in your work.

  1. Lesley, your email validation logic not completely correct I entered abc@gef and on click button it accept it, instead it should give error.

  2. You made it responsive but you did one mistake, as I try to scroll the page, I was not able to do it. Because you have used overflow-y: hidden; in body.

  So I hope you understand the problem and will solve your issue before anyone again tell you to alter it.

  Best Of Luck! Lesley

  Marked as helpful

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted almost 3 years ago

  @skyv26 Thanks Aakash

  1

  

  Lesley Kimutai•565

  @LeskimPosted over 2 years ago

  @skyv26 six months on 😂💀 finally dealt with all the issues

  1
• 

  Byron•2,290

  @byronbyronPosted almost 3 years ago

  Hi dude,

  One of my favourite js resources is Wes Bos' Javascript 30 course. It contains lots of little mini projects, much like FE Mentor, and it teaches a bunch of useful javascript techniques.

  Your base apparel page looks good! I'd also suggest checking your accessibility/html issues flagged by FE Mentor. 👍

  Marked as helpful

  0

  ---

  

  Lesley Kimutai•565

  @LeskimPosted almost 3 years ago

  @byronbyron Thanks Byron

  0