Submitted almost 3 years ago
article-preview-component using scss and BEM (my style 😎)
@mikib0
Design comparison
SolutionDesign
Solution retrospective
Why does css consumes too much time and how can i improve??
Community feedback
- @skyv26Posted almost 3 years ago
To avoid accessibility issues:
-
wrap everything in your body in <main> OR give role="" to the direct children of your <body> ... Click here to read more here
-
start your headings with <h1> and move up by one level each time
Change your code
<div class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </div>
To
<footer class="attribution"> Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. Coded by <a href="#">Your Name Here</a>. </footer>
Good Luck
Marked as helpful1 -
- @mikib0Posted almost 3 years ago
@skyv26 thank you very much for your feedback. I will focus more on accessibility in my future projects.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord