Article preview component with Vanilla JS

Community feedback

• 

  Zineb Boutaa•750

  @zineb-BouPosted about 3 years ago

  Your solution looks good on different screen sizes.

  • Setting h1 as a card title may look normal on this task since the card is the only component on the page, though this card would be part of a page in real production and a website should contain only one h1, so avoid choosing h1 as a card title you could choose h2 instead.

  • The social media icons are actually links, so you should put <a/>, add text inside it and make it sr-only then hide the SVG icons from the screen reader since they are purely decorative

  happy coding 🙂

  1

  ---

  

  Dušan Lukić•1,660

  @dusanlukic404Posted about 3 years ago

  @zineb-Bou yeah, of course on big project I would use only one h1. Thanks for such a helpful feedback 😀

  0
• 

  Ken•935

  @kenreibmanPosted about 3 years ago

  Hey! Your design and project looks great.

  For your <button class="card__footer--btn"> I would add `aria-label="Name" to be more accessible. You can read more about that here

  Don't forget to generate a new report after making those changes.

  I hope this helps!

  1

  ---

  

  Dušan Lukić•1,660

  @dusanlukic404Posted about 3 years ago

  @lmaoken Hey Ken! Thanks for your suggestion. Appreciate it 🙌

  0