Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Article Preview Component

P

@ZPolikarpov

Desktop design screenshot for the Article preview component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

P

@webdevbynight

Posted

Some feedback:

  • the shadow of the component is not similar to the one in the design (the $box-shadow-3 variable is most similar) and you forgot to add the shadow to the tooltip showing the links where to share;
  • you should avoid declaring inline styles: declare them within stylesheets (inline styles cannot be cached by browsers);
  • the first image (the drawers) is a decorative one and its alt attribute should be left blank (alt="") and the value of the alt attribute of the avatar should be something like “Michelle Appleton’s avatar”;
  • you should clean your React repo, since you do not use the accordion components (dead code should be avoided);
  • your SCSS is well organised, but a bit too much for this challenge: since there is only one component, you do not need to split into so many directories (by the way, I am not sure I manage to maintain your SCSS so that easily).

I hope this feedback helps you.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord