P
webdevbynight• 240
@webdevbynight
Posted
Some feedback:
- the shadow of the component is not similar to the one in the design (the
$box-shadow-3
variable is most similar) and you forgot to add the shadow to the tooltip showing the links where to share; - you should avoid declaring inline styles: declare them within stylesheets (inline styles cannot be cached by browsers);
- the first image (the drawers) is a decorative one and its
alt
attribute should be left blank (alt=""
) and the value of thealt
attribute of the avatar should be something like “Michelle Appleton’s avatar”; - you should clean your React repo, since you do not use the accordion components (dead code should be avoided);
- your SCSS is well organised, but a bit too much for this challenge: since there is only one component, you do not need to split into so many directories (by the way, I am not sure I manage to maintain your SCSS so that easily).
I hope this feedback helps you.
Marked as helpful
0