@vanzasetia
Posted
Hi, David Ochoa! š
Nice badges on your README! š
Here are some suggestions for improvements:
- No "avatar" word: Alternative text should not contain any words that are related to "image". The semantic meaning of the
<img>
element is already telling assistive technologies that it is an image. - Always add
focusable="false"
to all<svg>
elements:focusable="false"
is used to ensure old browsers will not allow the Tab key to navigate into the SVG. Source: Contextually Marking up accessible images and SVGs - Semantic HTML: Use a
<button>
element to create the share button. Wrap each social media icon with an anchor tag. - Accessible name: Make sure the share button and the social media links have a label. You can use the
aria-label
attribute. - Hide decorative SVGs from assistive technologies: Decorative images that are using inline SVG should have
aria-hidden="true"
to prevent them from getting pronounced by screen readers.
I hope this helps. Happy coding! š
Marked as helpful
@davidochoadev
Posted
@vanzasetia, as always the best, thank you so much for these wonderful suggestions. I will immediately implement the changes you have suggested! šš»āāļø
@vanzasetia
Posted
@davidochoadev
You are welcome! It looks like you have implemented my suggestions.