article component slution

Community feedback

• 

  P

  Michał•140

  @miedzygalaktycznygitPosted 6 days ago

  Hello, I’m not sure if my way is the best because I’m also just starting to learn, but I just made another div for socials, and with JS, I made it pop up on the screen when a button is clicked and disappear when clicked again. On the mobile design, I made the div with the photo disappear and replaced it with socials.

  
  button.addEventListener('click', () => {
      if (mediaQuery.matches && !landscapeQuery.matches) {
          divPersonalInfo.style.display = 'none';
          divSocials.style.display = 'flex';
      } else {
          if (isToggled) {
              divSocials.style.display = 'none';
          } else {
              divSocials.style.display = 'flex';
          }
          isToggled = !isToggled;
      }
  });
  
  button2.addEventListener('click', () => {
      if (mediaQuery.matches && !landscapeQuery.matches) {
          divSocials.style.display = 'none';
          divPersonalInfo.style.display = 'flex';
      }
  });
  

  • You can look on my code and feel free to use it to try to improve Your website.
  • And I think that You have small mistake that's making this bottom div looks weird

  background: linear-gradient(to bottom, white 90%, hsl(217, 19%, 35%) 100%);
  

  You simply write "background-color" and You should udes "background" instead

  • I hope that You can find my message helpful and I wish You best in Your future projects.

  0