advice-generator-app-main

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted over 2 years ago

  Hello Albaraa Adam ! Congo 👏 on completing this challenge

  Let's look at some of your issues, shall we:

  • Always use h1 first and then h2, h3 and so on

  • Input buttons must have discernible text

  happy Coding😀

  Marked as helpful

  1

  ---

  

  Albaraa Adam•230

  @AlbaraaAdamPosted over 2 years ago

  @Crazimonk thank you 🙏

  1

  

  Albaraa Adam•230

  @AlbaraaAdamPosted over 2 years ago

  @Crazimonk ok I have fixed them 👍

  1
• 

  teamie•470

  @tea-scriptsPosted over 2 years ago

  Great job completing the challenge!

  Some points to take note of:

  • Try as much as possible to separate your files and link them up in the html rather than having all different types of codes in your HTML like JQuery, in-line JavaScript. This is not set in stop but is considered best practice and helps separate concerns.
  • Do not use inline/internal styles when developing a website, you can create a .css file and set up your codes there.
  • The advice when fetched should be displayed in quotes " " and you seem to be missing that and might want to take a look at that.
  • You're supposed to have at least two layouts (desktop and mobile) but you've only got one. The challenge isn't only to test your coding skills but also your skills as a designer and this is one of the requirements of this challenge.

  Great work using JQuery to fulfil the task. You're doing great, keep pushing 👍!

  1

  ---

  

  Albaraa Adam•230

  @AlbaraaAdamPosted over 2 years ago

  @coder-teamie thanks 🙏🙏🙏

  0

  

  Albaraa Adam•230

  @AlbaraaAdamPosted over 2 years ago

  @coder-teamie ok I have fixed them 👍

  1