Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Advice Generator App - Async-Await fetch API - SCSS for styling

@guidofamula

Desktop design screenshot for the Advice generator app coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hallo guido here. This solution it's not perfect, various feedback will be appreciated.

Check source code in my Github.

Thanks.

Community feedback

Hikmah 1,070

@Hikmahx

Posted

Hi Guido. Nice work! I have some suggestions for you for the dice button:

  • To make the dice button circle, first off, you need to remove the border-radius, padding, margin-left and margin-right from the class button-dice img. You don't really need these classes on the img tag.
  • In the border-button class, add border-radius: 100%; to give the button a full circular shape. Also, add:
    padding: 1rem;
    background: #52ffa8; 
    display: flex;
    position: relative; 
    top: -22px;

Using display flex helps center the element in it. And by adding a relative position, you can shift the element upward (top) without using margin to do so.

  • In button-dice class, add
   width: 100%;
   display: flex;
   justify-content: center;

The above style is to simply center the dice button horizontally.

Hope this helps

Marked as helpful

1

@guidofamula

Posted

@Hikmahx Thanks Hikmah, i implement your feedback, this helpful to fixing the style generate button.

Thanks, once again.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord