@joaskr
Posted
Hi Tiff,
Good job with this challenge!
If you want to further improve your solution here are some tips:
- To get rid of Buttons must have discernible text accessibility error you can use aria-label on the button. It won't change anything on the screen but will make the button more accessible for users with screen readers. <button aria-label="Get new advice" class="button">. Here you can see more ways to fix that.
- Consider using rem and em instead of px for font sizes as they are better for responsiveness. Here you can read more about it.
- I would also recommend removing
console.log(data)
from the 8th line in app.js file beacuse leaving console.logs are considered a bad practice.
Overall, great job!
Keep coding and good luck with future challenges