
Design comparison
Solution retrospective
Hello, Frontend Mentor community! This is my solution to the Advice Generator app.
I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you
Please log in to post a comment
Log in with GitHubCommunity feedback
- @VaheAA
Hi! I noticed the same issue with the API call response in Firefox as i experience by myselfe while was doing this challenge. After first call you always get the cached response and result doesn't change. To solve it you can add to your fetch option "fetch(apiUrl, {cache: "no-cache"})". For more information https://developer.mozilla.org/en-US/docs/Web/API/Request/cache.
Besides that, nice work!
Marked as helpful - @GrzywN
Great job Catherine! Frontendmentor.io crew did something wrong and they didn't provide right color for the background in this challenge. I used the one from figma and it wasn't matching any of the colors in the
style-guide.md
file.My color variables look like this:
$dark-blue: #202733; $dark-grayish-blue: #313a48; $grayish-blue: #4f5d74; $light-cyan: #cee3e9; $neon-green: #53ffaa;
Hope this helps! Happy coding!
Marked as helpful - @Skidragon
It looks good though I keep getting a cached response when fetching for new advice. I believe it has to do with fetch since I used axios for mine, and you might have to do what this post suggested: https://stackoverflow.com/questions/29246444/fetch-how-do-you-make-a-non-cached-request
Just noticed its doing it on mine too. I think it might be firefox dev edition browser.
Marked as helpful - @Samadeen
Hey Catherine!! Cheers 🥂 on completing this challenge.. . I think your dice could use a little margin-top and the color can use a little filter to make it darker.
You Inspire me so much... Happy coding
Marked as helpful - @Sdann26
Hi Catherine!
You're right, I when I saw about the colors, they didn't fit the design. In my case I used the eyedropper to inspect the page to get the colors.
Obviously if you can't use the eyedropper because you have the image and not the web page, you can use this tool to take the colors.
https://imagecolorpicker.com/
- @zent0821
I like it, nice job.
- @salmansajib
The color is not ok but nice work.
- @Robert170304
hey you did a really good job and thanks your solution help me a lot to build this project.
- Account deleted
Boa, vejo que você está indo muito bem nos desafios, parabéns...
- @shashreesamuel
Hey catherineisonline, good job completing this challenge. Keep up the good work
Your solution looks great however I think in comparison with the design that the dice requires some margin-top.
I hope this helps
Cheers Happy coding 👍
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord