Solution responsive advice generator HTML, CSS, Javascript

Community feedback

• 

  Joanna Skrzypczak•530

  @joaskrPosted almost 2 years ago

  Hi Ítalo Gabriel, great job with this challenge! It looks awesome. I really like the loading spinner 😊

  There are a couple of things that you can improve - they are mostly related to accessibility:

  • Wrap your content in a <main> tag instead of using <div class="main">. Using landmark HTML elements such as <main> <header> <nav> <footer> is better for accessibility.
  • You are currently using a <h1> for a advice text and <h4> for advice number. I would consider using <h1> for the advice number because it is technically a header for the card content and <p> for the advice text. It feels more natural that way and generally we should use headers in order - so h1 then h2 then h3 and only then h4. You can read more about it here

  Let me know if you have any questions.

  Good luck with next challenges!

  Marked as helpful

  1