Advice Generator App

Community feedback

• 

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  Nicely Done 👏

  The HTML, CSS is well structured and the Script file is easy to read. I like how you centered the dice element using position and transform properties.

  positioning the card in the center is well done, another alternative way to do that would be body { display: grid; width: 100vw; height: 100vh; place-items: center; } or using flexbox also works.

  Thank You

  Marked as helpful

  0

  ---

  

  Aya•150

  @aya-94Posted over 2 years ago

  @karthik2265 Thank you Karthik! I love doing the challenges here and I'm learning a lot with every project :) I've heared tho for the accessibility problem I have I should use the h1 but wasn't sure if it was correct on the advice ID or the advice itself, any suggestions?

  0

  

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  @aya-94 yes it is recommended but not necessary, its a good idea to use H1 tag because it helps with screen readers and also useful in SEO.

  1

  

  Clement Idemudo•90

  @Clemcy9Posted over 2 years ago

  @karthik2265 this is very helpful. Your approach to correcting is very endearing 🥰

  0

  

  P

  Karthik suryadevara•825

  @karthik2265Posted over 2 years ago

  @Clemcy9 thanks 😄

  0