Skip to content
Submitted almost 3 years ago

Advice API using SASS and BEM

Vuekoā€¢160
@Vueko1
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Advice generator app
  • HTML
  • CSS
  • JS
  • API
2junior

Design comparison

SolutionDesign

Solution retrospective

Hello ! Could you please take a look at my code to make sure there are no mistakes ? Also I would like to know how to control the color and ratio of svg images you provided using css ( I found filter property but it turned out to be troublesome for me :P )

Community feedback

  • Vuekoā€¢160
    @Vueko1Posted almost 3 years ago

    Also ! I wonder why on mobile rolling the dice gets new advice instantly and on pc ( chrome in my case ) it seems to have a cooldown of few seconds ( like after clicking you have to wait a while before next one can be get )

    0
  • Emmilie Estabilloā€¢5,540
    @emestabilloPosted almost 3 years ago

    Hi @Vueko1, looks good. Can't tell if there's an issue with the svgs because it seems ok! Just a few thoughts:

    1. Use rem in place of px
    2. .dice-frame requires user interaction, and thus should be an interactive element button in this case, rather than a div.
    3. I think .wrapper can do away with all the flex properties. Its contents would still look centered and would likely just need padding in between. Less code, if you will.
    4. Hover on the dice could use a smooth transition

    Hope this helps!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord