A Recipe page using only HTML and CSS

Community feedback

• 

  P

  Levi•230

  @law973Posted about 2 months ago

  Hi! Nice job on using a media query. In order to create space between your ordered list numbers and the list items, use a ::marker selector instead of ::before; that way, adding left padding to the li elements will create the desired effect.

  There's a few other things to mention. I think h2 should be used in place of h3; the numbers should descend based on their position in the document. If, for example, there was a subsection in the "Preparation time" section, then it would make sense to use h3 there. I would also say that the headings should be contained within the divs they belong to and not outside of them.

  Regarding the usage of semantic HTML, I like that you used the main tag. It's worth noting that all of the main content should be placed within there, which would include the image. A footer tag could be used for the attribution section, the divs within the card could use section tags, and perhaps the card itself could use its own article tag.

  It seems like the repository is private, which means the "View Code" link doesn't function properly and the code can only be inspected through browser developer tools; I would consider changing this setup for future submissions in order to make it easier for others to deliver feedback.

  I've done this challenge myself, and I know it can be time-consuming to get the details right, so I'd like to commend you for doing a solid job on the padding, text color and sizing, and using the font families in the right places.

  I hope this helps!

  Marked as helpful

  0
• 

  P

  Karsten Løgstrup•90

  @logstrup78Posted about 2 months ago

  Hi Levi. Thanks a lot for your very nice feedback. I will definitely try to use the ::marker pseudo. I'm very grateful for your help.

  Karsten

  1