Design comparison
SolutionDesign
Solution retrospective
I would love to hear your awesome feedback on my solution
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans
,SUVs
andLuxury
are headings, but you can use the<h2>
tag instead of the<h1>
tag. You can read more about this here π.
- You should use the
<a>
tag instead of the<input type="button">
tag because theLearn More
button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here π.
I hope you find it useful! π
Happy coding!
Marked as helpful0@astr0n0merPosted almost 2 years agoHey @MelvinAguilar, thanks for your feedback
- I will update the headings used in the markup
- Thanks for pointing out the distinction in use cases for
<a>
tag and<input type="button">
element
0 - You should use only one
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord