3-column-preview-card-component-main using CSS grid and flex

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Great solution.

  Make sure to replace button tags with a tag because the purpose of a tag is redirection to another page. Buttons are useful when you want to create some interactivity on the same page, for example, pop-up modal or form submission. Definitely this is not a bug project and this buttons has no purpose right now however and it could potentially be a button as well but less likely, it’s good to have that habit of differentiating buttons and a tags😊

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  0
• 

  Joanna Skrzypczak•530

  @joaskrPosted almost 2 years ago

  Hi!

  Great job with the solution. I really like the end result 🎉

  I would only suggest changing small 2 things:

  • Switch a <div class="attribution"> to a <footer> - it is good for the accessibility to wrap all elements on your page with HTML landmark elements such as <main> <header> <nav> <footer> because it improves accessibility.
  • Don't forget about adding an alt text to the images that describe what's in the picture. In your code you left that value empty <img class="image" src="./images/icon-sedans.svg" alt=""> You can simply use alt="sedan icon" and it will improve the accessibility.

  Overall, great job!

  0