Design comparison
SolutionDesign
Solution retrospective
When in mobile size, I can not add margin-bottom, or space at the end of page
Community feedback
- @pyaetheiNPosted over 2 years ago
Hello! It took me a while to find out the problem,
I will explain step by step:
- remove
height: 50%;
max-height: 50rem;
min-height: 40rem;"
from your ".cards" class in style.css because of your height properties , it doesn't work in mobile screen - remove
overflow: scroll;
because it's ugly and addpadding: 5rem 0;
in your ".cards" class in responsive.css to have spaces between top and bottom of the page
That's the solution for your problem you're pretty much good to go after doing these steps.
Things you forgot to add:
- change card titles
font-family
- add
border-radius
on first and third card - add
line-height
in your ".card-paragraph"
In my humble opinion, I recommend you to avoid using heights too much. It isn't required in every layout, it automatically wraps up the content inside it.
1@PuppychanPosted over 2 years ago@pyaetheiN thank you very much! Your feedback has helped me a lot.
1 - remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord