Design comparison
Solution retrospective
Your feedback how to improve is always welcome 🤗
Community feedback
- @ecemgoPosted over 1 year ago
Some recommendations regarding your code that could be of interest to you.
HTML
In order to fix the accessibility issues:
-
You need to replace
<div class="container">
with the<main>
tag. You'd better use Semantic HTML, and you can also reach more information about it from Using Semantic HTML Tags Correctly. -
Each main content needs to start with an h1 element. Your accessibility report states page should contain a level-one heading. So, you need to use a
<h1>
element in the<main>
tag instead of using<h2>
. You can replace your<h2> Sedans</h2>
,<h2> SUVs</h2>
,<h2>Luxury</h2>
elements with the<h1> Sedans</h1>
,<h1> SUVs</h1>
,<h1>Luxury</h1>
elements.
CSS
- In order to center it correctly, you can use this style:
body { display: flex; justify-content: center; align-items: center; }
Hope I am helpful. :)
Marked as helpful0@SuebxlPosted over 1 year agoYes, it was very helpful.
Thank you, @ecemgo, 🙏 .
I have applied all your recommendations. I loved the article about HTML semantic you shared.
1@ecemgoPosted over 1 year ago@Suebxl I'm happy to help 🤩 That article has been written with fun, so I like it as well.🤗
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord