Design comparison
SolutionDesign
Solution retrospective
Feel free to give any feedback.
Community feedback
- @tedikoPosted over 3 years ago
Hello, Sk Saif Ahmed! 👋
Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:
- Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
- Since you're familiar with
Flexbox
there is no need to position your.container
with margin. Instead add these styles to yourbody
to align your container both vertically and horizontally:
display: flex; justify-content: center; align-items: center; min-height: 100vh;
Good luck with that, have fun coding! 💪
1@saifu-aPosted over 3 years ago@tediko Thanks for your feedback. I will modify my code to reflect the changes you suggested.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord