Had some struggles with this one. It was difficult to figure out how the hero image should look like on resizing and how to adjust it. It bothers me that it is so pixelated just before switching to desktop view... :/
zy
@zytuuAll comments
- @strosiSubmitted almost 3 years ago
- @farukwebcode21Submitted almost 3 years ago
This is my third challenge so if there is anything that can be improved please let me know. Thanks a lot. Any general feedback would be appreciated
@zytuuPosted almost 3 years agoHey there! Great looking solution and I'm glad that you're asking for feedback on your project. First of all, well done on achieving such a well proportioned card, that looks almost identical to the original's size.
As for things to work on, try using the font they provide you with in the styleguide.md file. I noticed you used the background image too, but you forgot to set the color of the actual <html> or <body> tag in your CSS so it just falls short of looking identical. The last bit of feedback I have is to try using the BEM naming conventions (if you're confused Kevin Powell has a really good video on it, I suggest checking that one out.), it makes working with nested divs (like the ones in ur card) a ton easier.
I hope I could help, and I hope we can both keep improving our skills on frontendmentor!
0 - @badnuclearSubmitted almost 3 years ago
Hello, I am a Korean who is trying the front-end challenge for the first time. As a result of the challenge, I implemented a page on the desktop, but I wonder how to implement the screen when viewed on mobile, and I don't know how to decorate the css of the footer, so I ask for feedback.
@zytuuPosted almost 3 years agoReally good looking project for your first time trying it! In regards to your question about the mobile styles, I would recommend developing your website for mobile before you try developing it for the desktop. Until just a few months ago I too, had the same problem.
Things to do: -Research media queries -Research flexbox and flex properties -Research mobile first design workflow!
I really hope this helps, I know I'm not a professional myself, but I do hope this can give you something to work towards. I look forward to your future projects on frontendmentor! :)
Marked as helpful0 - @RooseveltPaixaoSubmitted almost 3 years ago
Hey guys
I used position:absolute; for centralization. I didn't use Flex-Box, because I still haven't reached this stage in the PROGRAMADORBR course. After learning more about Flex-Box I will redo and post.
I'm learning and I'm open to constructive criticism on how best to align elements without using flex-blox.
@zytuuPosted almost 3 years agoI wouldn't wait to learn flexbox, its actually really self explanatory and you could save yourself positioning things with position absolute. That being said, your design is really well done! I look forward to seeing your revision with flexbox
Marked as helpful1