I'm proud of myself for doing mobile first and for figuring out grid for the first time, but by the end I realized I probably should have relied more on things like min-height, and less on things like padding with pixels to make things "pixel perfect" to the screenshot. Even though I know I shouldn't even be trying to do that XD Curious also about how I did with my use of semantic HTML elements!
Yui
@yteraiAll comments
- @maiaflowSubmitted about 2 years ago@yteraiPosted about 2 years ago
Great work Maia, you nailed it! I should definitely practice more using semantics elements like yours - thanks for a good example :) And kudos to you for doing all the challenges it's a huge commitment!
0 - @ericsalviSubmitted over 3 years ago
Any feedback is helpful and welcome.
I couldn't get working was because I had my modal set to -20px on the top and after the user submits the form, the top ends up being set back to 0. This way I could have the modal slide down slightly.
I ended up removing the code but I had it when the modal section had the class added from JS that says "modal-open" is when I was resetting the top. Why could I see the animation in the console but it was not triggering at all once the modal appeared?
@yteraiPosted about 2 years agoGreat work as always! I'd like to ask you a thing that I always have doubts about... How do you make line breaks responsive? I've added line breaks with <span> and ::before pseudo-element and it works fine. But this makes the HTML looks messy (too many <span>) and I just feel it's a bit hacky way? Your HTML/CSS doesn't look like mine at all and is very clean. I'd like to know what is your secret!
0 - @toyrobsSubmitted over 2 years ago
Aligning my page was one of the biggest issues I faced
@yteraiPosted over 2 years agoYour code looks neat and super clean! I'm gonna try that next time :)
1 - @ericsalviSubmitted over 2 years ago
Any feedback is great feedback!
One thing I did try using is TailwindCSS for this challenge and had a difficult time setting it up in Visual Studio Code. If anyone has any great examples/tutorials on how to use Tailwind for these challenges, that would be awesome if you could share.
Thank you.
@yteraiPosted over 2 years agoGreat job, my sensei Eric! I love how you organize the files and I'll refer to your Sass for the next time I use Sass :)
0