Skip to content
OverviewSolutions
6
Comments
5
Yılmaz ÇABUK
@ylmzcbk

All comments

  • Yılmaz ÇABUK•120
    @ylmzcbkPosted about 2 years ago

    Hi Alina,

    Congratulations on your solution! I've looked into your solution and my humble advices are:

    • Use <main></main> as wrapper for your body components.
    • Define a h1 title for your page.
    • Try using <section></section> where you can, instead of <div></div> for semantic reasons.

    Keep up your good work!

    0
  • Yılmaz ÇABUK•120
    @ylmzcbkPosted about 2 years ago

    Hi Simge, I reviewed your solution to this challenge and have some suggestions;

    • Use <main></main> tag for your content in body tag for landmarking.
    • Use <footer></footer> tag for your attribution section for same reason.
    • You may want to use dynamic values (em, rem) instead of px static unit as font size values.

    Congratulations, keep up your good works!

    Marked as helpful
    0
  • Enrica•170
    @ErriGarciaSubmitted about 2 years ago

    Hello guys! I found challenging to put the color on the image. Finally I found a solution. Do you have any other better solutions? Thank you in advice! Ciao :)

    Responsive card component

    2
    Yılmaz ÇABUK•120
    @ylmzcbkPosted about 2 years ago

    Hi Enrica,

    I reviewed your solution and found some parts to improve:

    • Try min-height: 100vh for container to not overflow page.
    • You may want to take a look dynamic values like rem, em, vw, vh etc. to have a dynamic page for different sized devices.
    • All page content should be contained by landmarks so you need to use <footer><footer/> tag for attribution section too.

    Well done, good work!

    0
  • Yılmaz ÇABUK•120
    @ylmzcbkPosted about 2 years ago

    Hi Erica, Your design looks perfect except horizontal rule you have at the bottom. About your HTML structure:

    • A page always must have a main tag.

    And you should definitely consider using dynamic measures like rem instead of px. This way your projects can look perfect on all screens.

    Nice work!

    Marked as helpful
    0
  • Yılmaz ÇABUK•120
    @ylmzcbkPosted about 2 years ago

    Hi Mircea! I reviewed your solution and realized that the following issues could be improved:

    • Solution should be suitable to 355px (because the sketch is done this way).
    • img tag's alt attribute should be different than actual text.
    • You shouldn't contain page's h1 inside header tag.
    • There's only one header in page and it is Gabrielle Essence Eau De Parfum.
    • main element must not appear as a descendant of the section element. Good work!
    0