Arturo Muñoz• 60
@artuino0
Submitted
I deploy this challenge in firebase, my code implements vue js to create using an array all the notifications and hide dont build elements if not required
Bingerminn
@yallsobad
All comments
- Bingerminn• 240
@yallsobad
Posted
You should add some Javascript to make it responsive. Minimum you could have it clear all the red dots, background color and notification counter at the top when "Mark all as read" is clicked.
Styling looks good tho!
Marked as helpful
0 - Paula Rodrigues• 250
@paulaabro
Submitted
I think the hardest part was to find a way to add the toggle icon and make it rotate, but I little thinking when a long way. I new how to make the toggle of the text because I had used
details/summarybefore onREADME.md. Is missing the two grayish lines couldn't get them so leaving it.Bingerminn• 240@yallsobad
Posted
Hey!
I would remove the height on the container so when you expand all the questions the container height increases as needed.
You could also put cursor:pointer under the summary element so it works on the entire element instead of just the text.
1 - Udoh Julie• 200
@Jey223
Submitted
Hi guys, I would love to get feedback on what I could not do right. Most especially with the CSS. I added a max-width of 100% to the overall container. Is that right?
Bingerminn• 240@yallsobad
Posted
Hi!
-I put 'margin: 0 padding: 0' in the * class at the top of the css. It's a good global reset. -Try putting a max-width on your overall container (.div--holder) with 'margin: 0 auto' to keep things tight and centered on large screens. -Add the hover properties to the social icons same as the button
0 - IRVINE MESA• 1,855
@DrMESAZIM
Submitted
I did this challenge in under 20 minutes . All feedback is welcome
Bingerminn• 240@yallsobad
Posted
Make sure to import and use the correct font. Put a container around your content with a max-width and 'margin: 0 auto'. It looks good on 1440px width, but above that it spans out.
0 - Timic Ivey• 300
@Lwmeek
Submitted
Any tips on improving my code? Would love all feedback, trying to get a lot better and more efficient.
Bingerminn• 240@yallsobad
Posted
Hi! Looks pretty good!
On my monitor the image cuts off at the bottom, so I would put a max width somewhere to prevent that.
I would put a container around your content with a max size and 'margin 0 auto' to center it
ex:
<main> <section class=container>or just <main class=container>
Marked as helpful
1 - Marius• 190
@MariusHor
Submitted
What do you think about this solution? Is there something I missed or that I can improve? Any feedback is welcome! 😉
Bingerminn• 240@yallsobad
Posted
Looks good! I like the fonts in :root I'm going to start using that.
In the code you could:
Use * {} to remove the default margins, instead of referencing every tag I used grid for the main container instead of flex
1
