All comments

@yadprabPosted over 3 years ago

@Alexander Great work, all the small intractions are cool. my only suggestion is seperate start button from the timer and make it look like a button its difficult to identify as a button.

0

Shahmir Faisal•480

@shahmirfaisalSubmitted almost 4 years ago

I tried my best to meet the requirements. But still, there's a bug. Any feedback will be appreciated!

React, Context and React Beautiful DnD.

@yadprabPosted almost 4 years ago

@Shahmir Faisal UI is perfect 10/10 then drag and drop is smooth great job

but Ux is not good users always enters the input value by pressing enter key in the keyboard the input tick is animation only remove that functionality just add submit event.

keep coding have a nice day :)

0

nysezgin•215

@nysezginSubmitted almost 4 years ago

Edit--Solved!: I would like to make my website in a way that when my user exits then re-enters, he still has all the created todo items from previous session on screen.

React JS, SASS

@yadprabPosted almost 4 years ago

@nysezgin great work use localstorage for store input

1

Ayya•40

@iraagyantiSubmitted almost 4 years ago

I'm using html, css and vanilla javascript for this challenge. My current code (of javascript) only allow me to open the faq one at a time, I also want to make the arrow rotate 180deg but It didn't work as I wanted to. I'd be happy if you could give your feedback on my code

Faq Accordion with pure html, css and javascript

@yadprabPosted almost 4 years ago

Hi iraagyanti, I have tried this but it has issues https://github.com/yadprab/pro-6/blob/main/js/main.js

Try this method if you find a solution notify me

Keep learning

0

Florian Andrieux•225

@GilliamsSubmitted almost 4 years ago

Any advice or constructive criticism is welcome. Thanks to you

faq-accordion-card

@yadprabPosted almost 4 years ago

this is CSS only great job. needs few changes remove 100vh in the body instead add 100% to the HTML element it prevents the jumpy container
then in mobile version icon and the question needs some margin and use button for icons so it makes easy to accessible then add width:100% and max-width to the container it also prevents the jumpy container

have a nice day

1

Mathieu FONTAINE•265

@mathieufontaineSubmitted almost 4 years ago

It was a nice challenge to test my JS knowledge! The drag and drop part is still confusing for me though... Any feedback or ideas to improve the app or simplify my code is more than welcome :)

Todo List App built with SASS and Vanilla JS

@yadprabPosted almost 4 years ago

hey Mathieu. great job. the footer looks cool my suggestion is to prevent users from entering an empty value that would avoid adding empty strings.

keep coding

0

Ayya•40

@iraagyantiSubmitted almost 4 years ago

I'm using html, css and vanilla javascript for this challenge. My current code (of javascript) only allow me to open the faq one at a time, I also want to make the arrow rotate 180deg but It didn't work as I wanted to. I'd be happy if you could give your feedback on my code

Faq Accordion with pure html, css and javascript

@yadprabPosted almost 4 years ago

hey it is because of hidePaneltext function

if you want toggle to functioning removes this function. for each time it adds and removes it still pressed and show class added to target element if you want this to be functioning with toggle maintain a state and toggle state add classes according to state. or make if statement based on an index and add classes

and for button use inline SVG and make SVG or img element unclickable by pointer-events none to avoid bubbling. make sure button is the target

great job keep coding

0

Marcin•570

@FrontmaniaacSubmitted almost 4 years ago

How can i remove the whitespace, on the bottom, on the two last divs( monthly subscription and why us) which appears on smaller devices?

HTML + CSS using grid

3

@yadprabPosted almost 4 years ago

Hey, the problem is because of grid-template-rows: 1fr 1fr 1fr; fr unit always takes up the free space use fr for large contents. Always use auto so it adjusts itself according the content Replace grid-template-rows: 1f auto auto;

Use firefox grid inspector it will help you to find the problem

Great job Keep learning 😊

2

Dawid•180

@mitow7821Submitted almost 4 years ago

Please test api and rwd on your devices and feel free to review my work.

URL shortening api

@yadprabPosted almost 4 years ago

The site looks cool. the loader and navigation animation is awesome 😊 great job

0

em•70

@emityiskaSubmitted almost 4 years ago

Hi, this is my second project. I am still a newbie so please advise if there is anything I can do better to improve the efficiency and the readability of my coding.

While working on the responsibleness for this project, it felt more like creating 2 different websites for mobile screen size and desktop screen size than because of the length of @media property.

For the bg-container In@media property, I had to set the height to 2000px because when I set the height to 100%, it didn't fill up the whole screen which made the bg-bottom to show up in the middle of the mobile screen.

I don't know why this happened because the bg-container div fills up the whole screen on the desktop screen with 100%height.

Thank you!

My first submittion in 2021 :) Social proof section master

@yadprabPosted almost 4 years ago

hey, you did a great job design looks perfect.don't set the height until its necessary remove the 2000px try 100vh or set html{ height:100% } and don't use position absolute only use it for overlay stuff div, section tags are block elements it will take up the height according to the content always start with mobile first approach look at the both design analayze structure html according to design

for cards, the grid is the best way to create responsive cards set card width using grid-template-columns(auto-fit, 300px) for card height use grid-auto-rows if the content is enough you don't grid auto rows

and for padding don't use percentages use em or rem

keep learning

2

Goksel•210

@gokselozSubmitted almost 4 years ago

Hi there! This was my first challenge. I am open to any constructive feedback, especially for how to create local storage Thanks in advance.

Todo app

@yadprabPosted almost 4 years ago

Hey UI looks perfect great job. First thing don't use var let and const are supported by all major browsers

And for input key down is a bit overkill use form and listen to the submit event it's easy to handle

For localstorage create an object then create an empty array check if localstorage.getItem('todo')===null Now push the user input object to array Set it localstorage.setItem(' todo','JSON.stringify(obj)) Else Get the data from Ls JSON.parse( localstorage.getItem('todo')) Update this array by pushing the next input

0

Marcin•570

@FrontmaniaacSubmitted almost 4 years ago

I fixed my solution and now it's all good with the responsivness.

FAQ accordion card