Skip to content
OverviewSolutions
20
Comments
7
César Palma
@xsrpm

All comments

  • César Palma•425
    @xsrpmPosted about 3 years ago
    • You could adapt your website for mobile devices.
    • I'm curious, with what tool did you model your website?
    Marked as helpful
    1
  • César Palma•425
    @xsrpmPosted about 3 years ago

    the font color of the header button appears to be white instead of hsl (204, 43%, 93%), otherwise it is almost identical. You can separate your css into files by target.

    Marked as helpful
    1
  • Gian Franco•290
    @gianbackSubmitted over 3 years ago

    Hello everyone, it is my first time uploading a project, I hope to learn a lot from your comments!

    grid, flexbox

    1
    César Palma•425
    @xsrpmPosted over 3 years ago

    You can separate the css code by target, it is a good practice.

    <link rel = "stylesheet" href = "style.css" /> <link rel = "stylesheet" href = "desktop.css" media = "screen and (min-width: 1440px)" /> You can check the uploads of others to review where to improve.
    Marked as helpful
    1
  • VIPenn•10
    @pennviSubmitted over 3 years ago

    If you have a moment, please offer comments! I'd really appreciate it! Also, I've since realized that I should not structure my CSS entirely with IDs (lol), and I will not do it henceforth! And also, I know the responsiveness is a bit shotty/sloppy, but, quite honestly, I just wanted to submit this and begin working on another one, as I spent more time on this than I'd like to admit. Thank you!

    Order Summary w/ HTML, CSS

    1
    César Palma•425
    @xsrpmPosted over 3 years ago

    The design is almost identical. Regarding what you comment on the use of ids, it is true you should not use them in this type of exercise, just to obtain a reference to a DOM element in javascript. In css with classes and specificity with tags it is enough. The BEM methodology also helps to correctly name the classes.

    1
  • César Palma•425
    @xsrpmPosted over 3 years ago

    Don't forget to use semantic tags like main and footer. Your solution is visually very similar

    0
  • Marialba Córdova•60
    @Marialba16Submitted over 3 years ago

    Hi guys, how are you? This is my third challenge, as in the previous ones, I would like to read your comments about how I can improve or what I should avoid when coding. Thank you!!

    Order sumary component

    1
    César Palma•425
    @xsrpmPosted over 3 years ago

    hello some feedbacks: 1- instead of

    <div class = "container"> uses: <main> 2- instead of: <div class = "attribution"> uses <footer class = "attribution">
    Marked as helpful
    0
  • César Palma•425
    @xsrpmPosted over 3 years ago

    be careful with the hover on the button, it is increasing the size of the container

    0