All comments

• 

  Baher Hesham• 60

  @BaherFalsh1102

  Submitted about 1 year ago

  All feedback is welcome thank you in advance :)

  

  QR code component

  2

  60

  

  wwheeler89• 30

  @wwheeler89

  Posted about 1 year ago

  Great start! I would add the right margin to the QR code like Jonatas mentioned but also make the border-radius on the QR code smaller. A good rule of thumb is half of what you used for the outer box. So around .6em.

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Abu Gaffer Rafat• 20

  @agrafat299

  Submitted about 1 year ago

  

  This is my first frontend mentor challenge.

  1

  10

  

  wwheeler89• 30

  @wwheeler89

  Posted about 1 year ago

  The preview isn't showing your work. I had a similar issue when I did my first challenge. On Github I originally clicked the link to import all the files, but for some reason, it wouldn't select the folders, so they weren't uploaded and I ended up with a similar message you have. I deleted and reuploaded everything, but the second time I just selected everything in my folder and drag/dropped them into Github and that seemed to work. Hope that helps. Good luck!

  0
• 

  wwheeler89• 30

  @wwheeler89

  Submitted about 1 year ago

  I'm a new coder and need a little help.

  Everything looks correct in the browser extension while working in VS Code, but when I click the URL on github.com there is an error with the QR Code image not showing up?

  Did I do something wrong? If so, please explain so I don't make the same mistake again.

  Thanks alot!!!

  

  QR Code Component

  2

  20

  

  wwheeler89• 30

  @wwheeler89

  Posted about 1 year ago

  I figured out the issue.

  I would still love any helpful feedback for improvement.

  Thanks.

  0