Abhijit Shankhdhar• 320
@im-abhijit
Submitted
hi all , please review my solution and give feedback if possible , i will really appreciate
Wiktor
@wiktor-rocks
All comments
- Wiktor• 110
@wiktor-rocks
Posted
Hi, I can't give you any useful feedback in regards to your CSS and HTML, because it's nicer than mine, but I can say something about the execution of the design. To me it looks like there should be more padding between the descriptions and the buttons, I think that look is quite nice. Also, it looks like the descriptions on the original design have a greater line height, which I also think is quite nice. Again, it looks like you're more advanced in CSS and HTML so I can't say much there. Great work overall.
Edit: I can also see that you didn't include hover states for you buttons.
Marked as helpful
1 - Wiktor• 110
@wiktor-rocks
Submitted
The whole structure of it is kind of weird. Instead of giving the containers a width I added padding to them and other elements, and it's just all weird. I will have to go back to some basic stuff so that my sites aren't built like that in the future. But it looks good...
Wiktor• 110@wiktor-rocks
Posted
I can now see that I will have to redo this at some point.
0 @Demiladeogo
Submitted
how do i make a responsive page?
Wiktor• 110@wiktor-rocks
Posted
Hi, one way to make a page responsive is to add something called a media query to your CSS stylesheet.
https://developer.mozilla.org/en-US/docs/Web/CSS/Media_Queries/Using_media_queries
Use something like this:
@media (max-width: 1250px) { /* … */ }
This way you can alter your CSS based on some criteria, in this case it's the screen width.
Marked as helpful
0
