@Tasin269Submitted 4 months ago
P
wecax
@wecaxAll comments
- @le-sampaioSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
What i'm most proud of it's the fact that i now can create simple pages more fast than i did before.
What challenges did you encounter, and how did you overcome them?The challenges it's more about use JavaScript together with HTML and CSS
- P@kisu-seoSubmitted 5 months ago
- @AVARUSJOSESubmitted 6 months agoP@wecaxPosted 6 months ago
Great job!
Your solution looks solid and well-written. I have no feedback to give other than fixing minor things related to designs (Text not filling out the div, inconsistent height )
0 - @EnrikeOmarFariasSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Hola! Fue un desafío intentar hacerlo con flex para la vista de escritorio por lo cual opte por utilizar position, espero seguir optimizándolo de todos modos
P@wecaxPosted 6 months agoGreat job on finishing your project!
I have a recommendation that could be helpful for you
- Using English as a primary language for naming elements. It will make your code more readable for your peers and mentors which will make it easier to provide quality feedback.
<body class="body-sombra"> <main class="contenedor-principal"> <div class="contenedor-secundario"> <header class="encabezado">```0 - @mojtaba-mehrzadSubmitted 6 months agoP@wecaxPosted 6 months ago
Your code is very well-structured and clean with sufficient documentation. I will be taking notes from your code for my next project. Great Job!
Marked as helpful0 - @AmneisaOBSubmitted 6 months agoP@wecaxPosted 6 months ago
I would change the body's height to 100vh instead of 150vh, it doesn't look centered because you need to scroll down.
Also, I would add breakpoints for tablet and mobile using "@media screen and (max-width: )"
Overall, your code is very well-written and structured. Good job!
Marked as helpful0 - @Hlm19966Submitted 6 months agoP@wecaxPosted 6 months ago
Overall, your work is well-structured and readable. The only nitpick I have is the styling, other than that, great job!
0 - @Chiwanza16Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Being able to center a div inside a div using the power of margin auto.
P@wecaxPosted 7 months agoGood job on finishing your project!
I think experimenting with different layouts such as Flexbox or Grid and redoing the project would be very beneficial for you to improve your craft
Keep it going!
0
