Skip to content
OverviewSolutions
10
Comments
8
Jeffrey Hill
@webdevhill

All comments

  • Jeffrey Hill•100
    @webdevhillPosted 11 months ago

    that's cool how you rendered that with forEach

    0
  • Jeffrey Hill•100
    @webdevhillPosted 11 months ago

    For this simple card I hard coded the width and height on desktop, 1080 x 446px. I like your use of a psuedo element for the overlay. Clean Code!

    0
  • Jeffrey Hill•100
    @webdevhillPosted 12 months ago

    That is spot on. Clean code. Nice work

    0
  • Jeffrey Hill•100
    @webdevhillPosted over 1 year ago

    I still am having trouble with my screenshots. Things look good in comparison with the previews but I am having trouble positioning the <main> component on the viewport.

    Maybe I should use Firefox for my screenshots?

    0
  • Jeffrey Hill•100
    @webdevhillPosted over 1 year ago

    consider wrapping your container in a <main> element and providing a viewport height for it, the 100vh on your HTML has no effect

    that should get is much closer for comparison

    there is a small typo

    hope that helps, Happy coding!

    1
  • Jeffrey Hill•100
    @webdevhillPosted over 1 year ago

    GitHub is not enforcing HTTPS on your page

    gudymedia.github.io throws an unsecured warning, here are the GitHub docs for HTTPS

    https://docs.github.com/en/pages/getting-started-with-github-pages/securing-your-github-pages-site-with-https

    0
  • Jeffrey Hill•100
    @webdevhillPosted over 1 year ago

    extremely close to an exact solution

    The responsiveness works very well.

    nice work!

    0
  • Philipe Rocha•30
    @phislipeSubmitted about 2 years ago

    🤖 Hi guys! Here's my solution to the "QR code component" challenge!

    Came back to this project after a while to improve the code, made some major changes in the CSS, and implemented display: grid instead of flex.

    ♻️ Changes:

    • Decided to refactor this project and use CSS grid instead of flex.

    As a newbie, I'll be happy to hear any feedback and advice!

    QR code component - HTML / CSS

    1
    Jeffrey Hill•100
    @webdevhillPosted about 2 years ago

    The proportions and size are spot on. Is it responsive below 375px? Not really, but it is a clean solution to the challenge.

    Well done!

    1