Skip to content
OverviewSolutions
36
Comments
4
Waleed Mumtaz
@waleedmumtaz

All comments

  • Waleed Mumtaz•670
    @waleedmumtazPosted over 2 years ago

    Amazing work Arsh! I really like the animations.

    Marked as helpful
    1
  • Leonard Isaac•40
    @leoimeworeSubmitted over 2 years ago

    My main difficulty was making the layout responsive. I initially tried move the images by positioning, but I learnt about CSS transforms. which was great.

    Another issue was reverting the active state of the questions back to grey in my JS. I am hoping someone can tell me what i did wrong

    FAQ CARD

    1
    Waleed Mumtaz•670
    @waleedmumtazPosted over 2 years ago

    Hi Leonard! Great work!

    You can actually use the HTML <details> tag to make things easier with FAQs and style it according to the design. You can read more about it here.

    HTML details Tag

    Hope this helps! 😀

    0
  • Neonita•80
    @neonitaSubmitted over 2 years ago

    Hi! I was wondering if anyone could give me a hand on how to change the email's placeholder value when a validation error is returned (like in the challenge's requirements). I tried to replace the placeholder value on my JavaScript file, in the email's conditional, like so:

    document.getElementsByName('email').placeholder='email@example/com';

// I also tried...

document.getElementsByName('email')[0].placeholder='email@example/com';

    I would greatly appreciate it, thanks!

    Sign up Form with Vanilla JavaScript

    1
    Waleed Mumtaz•670
    @waleedmumtazPosted over 2 years ago

    Hey there! I just went through your code. Firstly, in your checkInputs() function, it looks like you are checking for lastName instead of checking the email being empty. Changing lastName to email:

    // Email
if (
  email.value === '' ||
  email.value === null ||
  email.length === 0
) {
  displayError(email, 'Email address cannot be empty', errorEmail)
} else if (!validateEmail(email.value)) {
  email.placeholder = 'email@example/com'
  displayError(email, 'Looks like this is not an email', errorEmail)
} else {
  console.log('Email: ✅ Valid!')
}

    Secondly, "example@email/com" does not seem like placeholder text to me. I think it shows that the input by the user is invalid (the "/" being the invalid character here, instead of "."). That is the actual text entered by a user, and it gets a text color of red if it is invalid.

    Hope this helps! 😀

    Marked as helpful
    1
  • Kiyoomi•480
    @JukiyoomiSubmitted almost 3 years ago

    My first time using SvelteJS. I had a lot of problems with deploying, and I don't know how we can get EVERY border country when we go on the details of a country. Any feedback ?

    Countries API using SvelteJS

    2
    Waleed Mumtaz•670
    @waleedmumtazPosted almost 3 years ago

    Hey there! Great work! You could use the 'List of Codes' API endpoint to convert the country codes to their names and display them as country borders. That's how I did it. 🙂

    0