this is my second frontend challenge using js css and html,im still a newbie so if you have any recommendation im happy to listen!
wuts
@waldosmutsAll comments
- @marco3724Submitted over 2 years ago@waldosmutsPosted over 2 years ago
Looks great in both 1440p and 375p resolutions.
Might I suggest setting the width to auto on desktop resolution and adding some margin to the right of it. The same can be done for the mobile resolution by setting only the height to auto. If viewed in any resolution other than 1440p or 375p it causes the image to stretch.
When it comes to the mobile view of the side-navbar I'd recommend the having the dropdowns show on click instead of hover since clicking elsewhere causes the dropdown to disappear for mobile users.
Also just remove the shadow and background on the dropdowns in mobile view and remember to put your name and link in the footer.
Hope this was helpful!
Marked as helpful1 - @BenConfigSubmitted about 3 years ago
This is the first time I have tried to add a dark theme on a page. My switch works by adding a class when the switch is clicked which reassigns the custom property color values. Is it possible to animate the transition from light to dark like this or do I need to use another method?
@waldosmutsPosted about 3 years agoYou can animate the transition by adding a transition property to your elements. I set my body transition to 0.4s for all elements, should work for you too.
Marked as helpful1