Skip to content
OverviewSolutions
6
Comments
8
Vlad Solomon
@vlad-solomon

All comments

  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    Maybe you should try this one again after some more practice

    0
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    Hoping you'll make this work

    0
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    Why the modal on page load? It's useless and breaks the flow of the entire experience.

    0
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    You could add a second parameter to your fetch request like so:

    fetch("https://api.adviceslip.com/advice", { cache: "no-store" })

    This will stop the API from caching, and you would be able to make requests one after the other, bypassing those 2 seconds. If I were you, I would add this and get rid of the timeout animation, seeing as it's useless if you spam the generate advice button.

    Marked as helpful
    1
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    You should really fetch some advice straight away on page load to have it displayed already.

    Marked as helpful
    0
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    Nope, giving classes to the body DOM element is absolutely fine! It's pretty common to use the body for theme changes. Great work

    Marked as helpful
    0
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    That's what display flex is for!

    Marked as helpful
    1
  • Vlad Solomon•270
    @vlad-solomonPosted over 2 years ago

    It seems to me you're requesting info from the API every time a country loads and unloads - not even talking about how you are requesting information about its neighbors every time. This seems pretty cumbersome on both the API provider and your front-end.

    0