Skip to content
OverviewSolutions
6
Comments
8
Vlad Solomon
@vlad-solomon

All comments

  • Edwin_Owino•60
    @Edwin574Submitted almost 2 years ago

    I was unable to implement drag and drop.It was also hard to implement the summaries for the different tasks,

    TO DO APP

    1
    Vlad Solomon•270
    @vlad-solomonPosted almost 2 years ago

    Maybe you should try this one again after some more practice

    0
  • Valery Djanya•210
    @ketchanjiSubmitted about 2 years ago

    What did you find difficult while going through my project? Which areas of mycode are you unsure of? Do you have any questions about best practices?

    Advice generator

    1
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    Hoping you'll make this work

    0
  • Ogunniyi Samuel•430
    @StarisblackSubmitted about 2 years ago

    Its really challenging and I love it. Getting the border countries is really really challenging i spent days on that. And I'm happy i could get it done to this stage. Learn a lot of things in getting the project done. Thanks to those who have completed the project before, your work help when I'm stuck at some stage. I'm open to suggesting and advice. Still working on it

    Starisblack-rest-countries-api-with-color-theme-switcher-master

    1
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    Why the modal on page load? It's useless and breaks the flow of the entire experience.

    0
  • Maca•630
    @Maacaa0Submitted about 2 years ago

    Nice challenge, I learned a lot. First time I am working with API.

    I noticed, on mozzila firefox. It generates advice only once and then it is not getting another. Other browsers works fine (even mobile firefox).

    I have added a time countdown bar at the top of the container, since:

     "Advice is cached for 2 seconds. Any repeat-request within 2 seconds will return the same piece of advice."

    I also implemented the little flip animation on page load using AOS - Animate on scroll library. It's quite easy to use and looks nice.

    Suggestions are welcome.

    advice-generator-app-main

    1
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    You could add a second parameter to your fetch request like so:

    fetch("https://api.adviceslip.com/advice", { cache: "no-store" })

    This will stop the API from caching, and you would be able to make requests one after the other, bypassing those 2 seconds. If I were you, I would add this and get rid of the timeout animation, seeing as it's useless if you spam the generate advice button.

    Marked as helpful
    1
  • Kelly CHI•210
    @KellyCHI22Submitted about 2 years ago

    Hey there, this is my #12 challenge ✌️ And also my first challenge of Junior level. It's really fun to work with different APIs. Wish there could be more challenges related to APIs on Frontend Mentor! Thank you for reviewing my code, I am happy to hear any suggestions :)

    Random advice generator app using Axios

    2
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    You should really fetch some advice straight away on page load to have it displayed already.

    Marked as helpful
    0
  • martin nkemakolam•260
    @martinnkemakolamSubmitted about 2 years ago
    • I used the body dom object in making sure i can toggle to dark mode or light is that bad?

    React js

    2
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    Nope, giving classes to the body DOM element is absolutely fine! It's pretty common to use the body for theme changes. Great work

    Marked as helpful
    0
  • Tony•50
    @Snorri967Submitted about 2 years ago

    I found it difficult to align the current price and old price design until I found out that it would be easy by putting the elements in a table data cell and adding display : table-cell; to the stylesheet.

    Product Preview Card Component

    2
    Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    That's what display flex is for!

    Marked as helpful
    1
  • Vlad Solomon•270
    @vlad-solomonPosted about 2 years ago

    It seems to me you're requesting info from the API every time a country loads and unloads - not even talking about how you are requesting information about its neighbors every time. This seems pretty cumbersome on both the API provider and your front-end.

    0