Skip to content
OverviewSolutions
1
Comments
1
Varun Sharma
@varunsharmablog

All comments

  • Varun Sharma•30
    @varunsharmablogPosted over 2 years ago

    Hey Yahir, Congratulations on your solution.

    I looked at your code and I believe the way you did the border radius absolutely matches the solution. Infact, I have adopted it into my own solution. I was defining the border radius with percentages, but when I defined it with pixels, it just looked so much better. I wish I had more free screenshots for this month so that I could compare the design and my solution after changing the border radius.

    As far as the dimensions go, If you can get the containers dimensions to be 320x497 px and the QR code images dimensions to be 288x288 px, it would be identical to the dimensions of the solution. Your current dimensions are 311x490.89 px for the container and 279x279 px for the QR code image which is why it looks a bit different.

    Also, wrap the container in the <main> tag for accessibility.

    Other than that, your code seems perfectly fine. Good job!

    Marked as helpful
    1