Skip to content
OverviewSolutions
8
Comments
6
Uzair Ahmed
@uzzii-21

All comments

  • Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Hi, Hope you are Good I have seen your solution and it's really nice and you code is well structured.

    but I wanna give you some feedback,

    try to use semantic tag instead of div, like (main , section, header, footer etc.).

    try to use (rem, em, px) for small components instead of %.

    hope this will helpful for you :)

    Marked as helpful
    0
  • Darren Wong•110
    @wongd-hubSubmitted over 2 years ago

    Hey all - would appreciate any comments you may have on the JS implementation here, unsure if I've been the most efficient I can be.

    Advice generator app

    2
    Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Hello @wongd-hub Hope you are well. I checked your solution and you did a great job :)

    Here is my feedbacks

    • If you are using only one heading tag, make sure it should be * h1 *. And if you are using more than one heading tag then make sure it should be in logical order like: first h1 then h2 ...
    • Note that you cannot use more than one h1 in a page but h2, h3 you can.
    • Add a lang attribute to the html element (e.g. <html lang="en">) whose value represents the primary language of document.
    • Anchor tag must have discernible text if you can't use text then you should use aria-label

    Hope it will help you :) Happy Coding

    Marked as helpful
    0
  • Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Hi @aleksFedotov I have checked your Challenge it's awesome and the animation that u have added it's really cool

    Although here is my feedback feedback related to some HTML and ACCESSIBILITY ISSUES

    • Ensure headings are in a logical order. for example: use at least one heading tag in a page n that should be h1 tag and if want to use more then one heading tag make sure that you are using heading tags in a proper order Like first use h1 then h2 ...
    • if you want to use custom attribute in html then use data-* attribute
    Marked as helpful
    0
  • Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Hi @ SAM-dev-pixel You did a great job.

    This is my feedback related to ACCESSIBILITY issues. Use semantic tags instead of div, such as: (main, header, section) Second, do not leave any ALT attributes blank. and the last thing use at least one heading tag in a page :)

    Marked as helpful
    1
  • Ben•770
    @BenConfigSubmitted over 2 years ago

    Thank you for checking out my page. Any feedback is greatly appreciated. :)

    Advice Generator App

    1
    Uzair Ahmed•170
    @uzzii-21Posted over 2 years ago

    Good job bro :)

    1
  • Uzair Ahmed•170
    @uzzii-21Posted about 3 years ago

    i think you put your repo link in the site-url input please re-submit your work

    0