Aya Zayed• 200
@AyaZayed
Submitted
Uzair Ahmed
@uzzii-21
All comments
- Uzair Ahmed• 170
@uzzii-21
Posted
Hi, Hope you are Good I have seen your solution and it's really nice and you code is well structured.
but I wanna give you some feedback,
try to use semantic tag instead of div, like (main , section, header, footer etc.).
try to use (rem, em, px) for small components instead of %.
hope this will helpful for you :)
Marked as helpful
0 - Darren Wong• 110
@wongd-hub
Submitted
Hey all - would appreciate any comments you may have on the JS implementation here, unsure if I've been the most efficient I can be.
Uzair Ahmed• 170@uzzii-21
Posted
Hello @wongd-hub Hope you are well. I checked your solution and you did a great job :)
Here is my feedbacks
- If you are using only one heading tag, make sure it should be * h1 *. And if you are using more than one heading tag then make sure it should be in logical order like: first h1 then h2 ...
- Note that you cannot use more than one h1 in a page but h2, h3 you can.
- Add a lang attribute to the html element (e.g. <html lang="en">) whose value represents the primary language of document.
- Anchor tag must have discernible text if you can't use text then you should use aria-label
Hope it will help you :) Happy Coding
Marked as helpful
0 - Aleksandr Fedotov• 1,060
@aleksFedotov
Submitted
Feedback will be highly appreciated
Uzair Ahmed• 170@uzzii-21
Posted
Hi @aleksFedotov I have checked your Challenge it's awesome and the animation that u have added it's really cool
Although here is my feedback feedback related to some HTML and ACCESSIBILITY ISSUES
- Ensure headings are in a logical order.
for example: use at least one heading tag in a page n that should be
h1 tagand if want to use more then one heading tag make sure that you are using heading tags in a proper order Like first use h1 then h2 ... - if you want to use custom attribute in html then use data-* attribute
Marked as helpful
0 - Ensure headings are in a logical order.
for example: use at least one heading tag in a page n that should be
- SAM• 900
@SAM-dev-pixel
Submitted
I would love to see any feedback ❤️
Uzair Ahmed• 170@uzzii-21
Posted
Hi @ SAM-dev-pixel You did a great job.
This is my feedback related to ACCESSIBILITY issues. Use semantic tags instead of div, such as: (main, header, section) Second, do not leave any ALT attributes blank. and the last thing use at least one heading tag in a page :)
Marked as helpful
1 - Ben• 770
@BenConfig
Submitted
Thank you for checking out my page. Any feedback is greatly appreciated. :)
Uzair Ahmed• 170@uzzii-21
Posted
Good job bro :)
1 - Nida Ismail• 70
@nidaismail
Submitted
I am looking forward for your feedbacks.
Uzair Ahmed• 170@uzzii-21
Posted
i think you put your repo link in the site-url input please re-submit your work
0
