Latest solutions
- Submitted 4 months ago
QR Card Component
- HTML
- CSS
Kindly feel free to go through my code and suggest any edits, specially with my approach on utility classes and my case study.
One thing I would specifically like to know is that even after using same font size and line height, my heading element appears to be a little larger than the one in the design. I would love a feedback on that, Thank you!
Latest comments
- @AibaiheSubmitted 4 months ago
- @HamedSamavatiSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
it was easy- but being detail oriented would be my mindset for next proj.
What challenges did you encounter, and how did you overcome them?remembering some properties
P@umwebdevPosted 4 months agoHey Hamed, Good job on your first challenge, however there is a lot of room for improvement. I would break everything down into bullet points for you so its easier to implement these changes
-
Try giving meaningful classnames to the elements, it would save a lot of time when you are revisiting the code after a few days or weeks
-
don't add height to an element explicitly, this would introduce overflow issues when the content gets larger than the height you have mentioned
-
when you need spacing inside an element, try giving padding to the parent element instead of giving margins to the children elements
-
instead of giving margin-top to the second element, give margin bottom to the first element. This would keep the spacing even when you delete the second element.
-
learn and use css variables, or custom properties. that would save you ton of time, here's a video that'll help you quickly grasp the css variables https://www.youtube.com/watch?v=NtRmIp4eMjs
-
try using rem instead of pixels,, here's a great tutorial on learning the html css fundamentals by john smilga aka coding addict, it has time stamps for you to navigate easily https://www.youtube.com/watch?v=-8ORfgUa8ow
I know that's a lot of suggestions, kindly don't get overwhelmed and take your time to implement those, it took me months to grasp all those concepts and the tutorial from john smilga is superb to learn the fundamentals.
0 -