Skip to content
OverviewSolutions
4
Comments
1
Tuan Ngo
@tuanngo1993

All comments

  • Nick Carlisi•180
    @nickcarlisiSubmitted about 3 years ago

    Hey everybody, I would appreciate any feedback. There's a few things that I couldn't quite figure out.

    • How to change the color of the SVG images. In dark mode, they're supposed to be white. Also, when something is 'Not Available' (i.e. twitter handle) it's supposed to be greyed out. I can't figure out how to change the color at all, let alone how to programmatically change it when something is 'Not Available'.

    • Another thing that's driving me crazy is that when the screen width gets too small the button gets pushed out of the form. Even worse, when the 'No result' error is there, it pushes it even further and 'No result' goes to 2 lines, for some reason.

    • Also, I feel like I could definitely refactor some of my javascript. This is my first "junior" project, after doing a few "newbies".

    Thanks in advance for any help!

    Good practice using Sass, JavaScript, API and Grid

    4
    Tuan Ngo•95
    @tuanngo1993Posted about 3 years ago

    Great job! It would be nice if you challenge yourself with bonus requirement that is to keep theme being like previous state by using localStorage(). For example, your theme is light mode at the beginning then you switch it to dark and it should be dark after refreshing page as well

    Enjoy your journey :D

    Marked as helpful
    0