Skip to content
OverviewSolutions
9
Comments
9
tris6
@tris6

All comments

  • tris6•150
    @tris6Posted 13 days ago

    Impeccable code! JS is efficient. CSS has fantastic use of min-/max- properties and sizing with relative units.

    0
  • tris6•150
    @tris6Posted 20 days ago

    Really efficient code, especially with the use of pseudo-selectors.

    End result itself looks great! Only fault I can see is the alignment of the icons in the share bar.

    Marked as helpful
    0
  • tris6•150
    @tris6Posted 27 days ago

    Nice! I'm studying your CSS because the methods are quite different to mine.

    Looks like the background color and card gap is a little off.

    0
  • tris6•150
    @tris6Posted 29 days ago

    Nice efficient code! I'm studying your use of selectors and properties to do this in only 120 lines.

    I've read in a few places it's good to only have one <H1> in a page. Might be something to watch out for.

    There's also room to match the box sizing and title formatting more closely. But as a learning experience I can understand there's not much to be gained from this detail.

    0
  • z-mn•150
    @z-mnSubmitted 4 months ago
    What specific areas of your project would you like help with?

    Any form of feedback as to where I can improve would be appreciated.

    Responsive card using media queries

    1
    tris6•150
    @tris6Posted 4 months ago

    Great code organization and nice use of reusable skin classes! And thanks for introducing me to place-content property. (Where this been all my life? I've been using two lines like a sucker!)

    Just a little flag that your H1 is a little smaller, thinner and spacier than the design. But, I do prefer your look to the mockup, so not neccessarily a bad thing.

    Marked as helpful
    0
  • tris6•150
    @tris6Posted 4 months ago

    Nice work! I can't work out why ingredients and nutrition section have the left padding, couldn't see a code issue causing it. For the >tablet media query it looks like <H1> design has more letter spacing. I missed this as well, only noticed after submitting.

    0
  • tris6•150
    @tris6Posted 4 months ago

    Nice! Great idea to use <strong> semantics for "Learning".

    0
  • tris6•150
    @tris6Posted 4 months ago

    Looks good! Great use of React components. CSS structure easy to follow.

    0
  • tris6•150
    @tris6Posted 4 months ago

    Looks great! Love the attribution. I think 250px img width would equal the design closer, and makes text read easier. But that's a nit-pick.

    0