Skip to content
OverviewSolutions
20
Comments
1
P
Treasure Kabareebe
@trekab

All comments

  • Treasure Kabareebe•290
    @trekabPosted over 2 years ago

    Nicely done, @Yahir-am! I like your use of CSS variables. They make your CSS readable and more maintainable. However, here are some suggestions to make your page look even better:

    • The mobile version appears to have some excess bottom white spacing after the button. Clearing this would make your page look more like the design spec.
    • It would also be great to provide a fallback font whenever you specify a font family in your CSS. e.g. font-family: "Montserrat", sans-serif; would imply that sans-serif is the fallback font. I find the introduction of this article(CSS Fallback Fonts) insightful about fallback fonts.
    • Finally, writing mobile-first CSS is a nice practice to follow when building responsive web pages. Here is a great article for more insight.

    I hope you find this feedback beneficial

    Happy coding!

    Marked as helpful
    0