@UgonadiaSubmitted about 2 years ago
I will appreciate any feedback on how I could have done this better especially the media queries part of my code.
Trae Zeeofor
@traezAll comments
- @traezPosted about 2 years ago
Nne welcome to frontendmentor. Github seen. You're doing well. Keep building and learning!
For starters you can take note of the Accessibility report (2) and HTML validation report (5) outstandings, and start to perfect your craft from there.
The media query wasn't really good. Responsiveness wasn't neat. But it's your first try and it's allowed. Google and look for an article that explains how to implement media query (when shifting from mobile to desktop and vice versa)
https://traez.github.io/time-tracking-dashboard-main/ You can check out my latest project and see how the look changes when you toggle mobile and desktop view.
Marked as helpful0 - @Abdelrahman0KhaledSubmitted over 2 years ago
I am still learning .. and I did not pass the course I am studying from to (Media Query).i took this challenge to apply what I learned, not as a challenge i have a problem >> why border radius not work on .card div? all feedback is welcome
@traezPosted over 2 years agoWell done Abdel, considering you're new. Please consider reading this article for a better understanding of media queries, It demystified the topic for me:
https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Media_queries#how_to_choose_breakpoints
Try border radius on both item and it's container. Play around, one would work. That was my experience too.
Marked as helpful0 - @ShinjiX-WebSubmitted over 2 years ago
- What did you find difficult while building the project?
- I find it was hard at the start dealing with CSS with flexbox. This is the first time I built a project like this for a long time.
- Which areas of your code are you unsure of?
- I was unsure what declarations to use in CSS.
@traezPosted over 2 years agoWell done! God job. You could have however used margins to space out the texts.
0
