@steven-barkley
Submitted
It took me a day to complete. It was a great exercise and one I need to revisit once I get feedback. It really woke me up to my skill gaps and lack of comfort with responsive design.
Tony Ruiz
@tonyruizo
All comments
- Tony Ruiz• 55
@tonyruizo
Posted
Hello Steven!
Check out those accessibility issues in the report, easy fix for that is to wrap your html div contents inside a landmark, as in <header></header, <main></main>,<section></section> and <footer></footer>.
Also don't forget the mobile design. Look into some CSS Grid and media queries and you should be able to make it happen.
1 - ZJStrinic• 120
@ZJStrinic
Submitted
Added shadow for more aesthetic look.
All suggestions to improve are welcomed :)
Tony Ruiz• 55@tonyruizo
Posted
Looks really good!
In the html you should wrap your <div class="attribution"> inside a <footer></footer> for that html validation report. I had the same issue with one of my challenges. Also, check out all this shadowbox examples from this site https://getcssscan.com/css-box-shadow-examples , they have really smooth looks.
1
