Can someone review my work and give feedback, best practices, how you would do certain aspects differently. Any feedback would be highly appreciated.
Tomiwa Orimoloye
@tomiwaorimoloyeAll comments
- @prajwal18Submitted about 3 years ago@tomiwaorimoloyePosted about 3 years ago
Nice work bro, but don't forget to put in some placeholders. By the way, your calculation, for the total price seems to be a bit flawed, try to cross check that too.
0 - @ThanhVuong0904Submitted about 3 years ago
-Hi everyone ! -I first coded in scripts2.js and then I improved the code in scripts.js. -Please tell me if there is something to improve in my code.
@tomiwaorimoloyePosted about 3 years agoNice work bro! You should also take a look at your accessibilities / HTML issues. Regardless, you did a great job.
0 - @johnpaul18Submitted about 3 years ago
I'm new learning React, please guide me.
- @GerriEzeochaSubmitted about 3 years ago
Any feedback is welcome, especially regarding JS.
@tomiwaorimoloyePosted about 3 years agoHey, Your work looks great! However you should try fixing the responsive layout at (775px - 1175px) screen width And you also got some accessibility issues that need to be resolved. Regardless, nice work
1 - @gerardguydavisSubmitted about 3 years ago
This was mostly completed with SCSS and Vanilla JS.
I wasn't quite sure what the design prompt was intending with the blue subscription card. I thought it was supposed to be a selector, and I kind of like it better that way, but the preview looks a little off because of it 😅 (The footer background is set to fixed, which I think also caused some issues with the preview. I guess I could have made that background image its own separate div.)
I'm mostly happy with how this turned out, but I'm almost certain there was a better, more DRY way to handle the drop down menu on the signup page. I probably should have used React for this. Oh well...
@tomiwaorimoloyePosted about 3 years agoHey, great work! but don't forget that the Pro pricing component has a
background-color: blue
by default0 - @manojks092Submitted over 3 years ago
Any feedback to mitigate or manipulate the code is highly appreciated.
@tomiwaorimoloyePosted over 3 years agoTry to set a max width for the main container and center it so it doesn't stretch on wider displays.
0 - @aguiimaraesSubmitted over 3 years ago@tomiwaorimoloyePosted over 3 years ago
Try generating a new screenshot so ur solution is easier to view directly from the solutions tab because currently it shows a 404 page on the screenshot.
Marked as helpful0 - @matthewjdavisonSubmitted over 3 years ago@tomiwaorimoloyePosted over 3 years ago
Your design is near-perfect but don't forget to add the background image. Apart from that, great job!
Marked as helpful0 - @caioalvespSubmitted over 3 years ago@tomiwaorimoloyePosted over 3 years ago
Nice work! But you missed some touches. Don't forget to add the box-shadow property to both the component and the primary button and put the background-image behind the whole component. With that, I'd say ur work will be better.
Marked as helpful1 - @arkharman12Submitted over 3 years ago
Any feedbacks are welcome :)
@tomiwaorimoloyePosted over 3 years agoYour solution looks pretty accurate. You could however check for responsiveness. For example on a 2560 x 900 display, the site starts to look a bit off. You can tackle this by using chrome dev tools and adjusting the width of your container. A hack is to set a max width of the container and center it. And wrap it up by fixing your accessiblity issues.
0 - @LucasDamasceno-SSubmitted over 3 years ago
I had considerable difficulty getting the card centered in the beginning. But in the end I think I managed to do something relatively ok. The site has a certain degree of responsiveness and can adapt to cell phones with 300px width
@tomiwaorimoloyePosted over 3 years agoYou did good. Nice job! An easier way to center it is to use flexbox on the container of the item you want to center.
0 - @mghadiehSubmitted over 3 years ago
I have used lots of nested flex box displays. I am not sure if that is a good thing or not, but it got the job done.
@tomiwaorimoloyePosted over 3 years agoI think it's okay to use a lot of nested flex containers in this particular project. From the description of this project, the purpose was to test your layout skills using either Grid or FlexBox.
0