Mostafa Saafan• 30
@MostafaSaafan123
Submitted
Hello, I would like feedback, if there are something I can improve.
Thanks :)
Théo-Selim
@theooow
All comments
- Théo-Selim• 60
@theooow
Posted
Hello ! Your card is insane but I think you can make it more similar to the example. I have the feeling that the font-size and font-weight for the text and the author name are a little bit too big ? In any case, the font-weight for the date is too thick. I think you can round more the card. That said, congratulations ! :)
Marked as helpful
1 - DaFlusher• 350
@DaFlusher
Submitted
It was quite a struggle to get the background images to align properly, even with the background said to no-repeat, there were still some grey areas of repeating images. I tried to keep the code DRY by using props and hooks to create reusable components. The height of the side navigation also looks weird in some places. I think it comes from the fact that all the main navigation pages received a page layout component which contained preset styles for navigation. With each of the pages having different heights, 100% no longer worked. I tried using the height: calc(100vh + extra pixels from the navbar), 100vh, 100%. None produced a uniform height for the side nav. In future projects, I would definitely try another approach. Any advice on best practices?.
Théo-Selim• 60@theooow
Posted
Hey, you can use background-size: contains; to fixes your background ! Good job
0
