Quick question, built this with vite/react and deployed it with vercel, anyone know why the images don't show up?
Vicente
@thekingviceAll comments
- @thekingviceSubmitted almost 2 years ago@thekingvicePosted over 1 year ago
Fixed the images. File structure problem, first time using React, didn't know images go in public.
0 - @graquSubmitted almost 2 years ago
My solution for this card ;)
@thekingvicePosted almost 2 years agoThis looks great! If you notice, the original design has a slight box shadow, which really helps the card stand out. Here's a link to MDN docs where they explain box shadow:
https://developer.mozilla.org/en-US/docs/Web/CSS/box-shadow
Hope this helps!
Marked as helpful0 - @7denizSubmitted almost 2 years ago
so here is my product card design for pc. What do you think about it? Any comment is appreciated. Thank you so much.
@thekingvicePosted almost 2 years agoI would suggest looking into media queries to make your design responsive, I noticed your site doesn't do anything when I make the window smaller. Here's a great video explaining them!
https://www.youtube.com/watch?v=yU7jJ3NbPdA
Hope this helps!
0 - @NinunutsiSubmitted almost 2 years ago
Any advice will be helpful.
@thekingvicePosted almost 2 years agoLooks pretty good! You should definitely try to move away from using pixels as a unit, and try to use relative units like rem. Also I know divs are easy but I would explore semantic HTML so your code can be a little bit more descriptive.
Here's some great videos to help you on your journey, they cover CSS units and semantic HTML:
CSS UNITS: https://youtu.be/N5wpD9Ov_To
SEMANTIC HTML https://youtu.be/kGW8Al_cga4
PS: If you want a bit more JS practice, try making it so that when you open one option all the other options close. Hopefully that makes sense, if not hit me back!
Marked as helpful0 - @sirbiel100Submitted almost 2 years ago
Your feedback will be really helpfull!
@thekingvicePosted almost 2 years agoLooks pretty good! You should definitely try to move away from using pixels as a unit, and try to use relative units like rem. Also I know divs are easy but I would explore semantic HTML so your code can be a little bit more descriptive.
Here's some great videos to help you on your journey, they cover CSS units and semantic HTML:
CSS UNITS: https://youtu.be/N5wpD9Ov_To
SEMANTIC HTML https://youtu.be/kGW8Al_cga4
PS: CSS has a letter-spacing property, so you don't have to space the letters manually!
<p id="paragraph">P E R F U M E</p>Here's a webpage explaining this property: https://www.w3schools.com/cssref/pr_text_letter-spacing.php
Marked as helpful0 - @NepcenSubmitted almost 2 years ago
My solution for QR code component challenge. Do you have any suggestion?
Links
- GitHub: Nepcen
- LinkedIn: Yusuf Abacık
@thekingvicePosted almost 2 years agoLooks pretty good! You should definitely try to move away from using pixels as a unit, and try to use relative units like rem. Also I know divs are easy but I would explore semantic HTML so your code can be a little bit more descriptive.
Here's some great videos to help you on your journey, they cover CSS units and semantic HTML:
CSS UNITS: https://youtu.be/N5wpD9Ov_To
SEMANTIC HTML https://youtu.be/kGW8Al_cga4
Marked as helpful1