Skip to content
OverviewSolutions
16
Comments
3
Fathul Irfaan Abdillah
@thefathdev

All comments

  • Fathul Irfaan Abdillah•320
    @thefathdevPosted about 2 years ago

    Hey David, great job for completing the challenge!

    Here's what I think you can do to fix the background :

    1. change background-image: url("pattern-background-desktop.svg"); in styles.css to background-image: url("../images/pattern-background-desktop.svg"); and don't forget to move your pattern-background-desktop.svg to the images folder
    2. add css property min-height: 100vh in the body selector, so your background will fill the entire view

    hope this helpful! happy coding✨

    Marked as helpful
    0
  • Fathul Irfaan Abdillah•320
    @thefathdevPosted about 2 years ago

    Hi MhmodMD! Great job with your design ✨ To make your intro section align in the middle of the page, you can

    • add css properties {display: flex; align-items: center; justify-content: center;} to the .main selector
    • pull out header element to be a body element's direct child
    • add some padding to header
    • and, switch the background image from .main selector to body

    Hope this helpful! Happy coding 🙌

    Marked as helpful
    0
  • Fathul Irfaan Abdillah•320
    @thefathdevPosted over 2 years ago

    Hi MhmodMD 🙌

    You're really doing great job on this challenge, congrats!

    To fix the mobile container problem, you may try this:

    1. you may specify max-width property instead of width in .parent .card class selector
    2. you may add margin-inline property in .parent .card to make space between the card and the both side of the screen Anyway, I've made a pull request to your repository ⬆️

    I hope this feedback is helpful, happy coding! ✨

    Marked as helpful
    1