Skip to content
OverviewSolutions
2
Comments
2
Salko Balić
@thedev966

All comments

  • Salko Balić•40
    @thedev966Posted over 3 years ago

    For mobile responsiveness, you need to use media-queries. Look it up on google and practice it. If this is your first project in web development, then it's fine. However, there is a lot of to improve on it. Good luck.

    0
  • AbdulKareem•170
    @seniorteckSubmitted over 3 years ago

    hi everyone, this is the second time I am taking this challenge, the first time I did it then 3months ago I could not figure it the layout, I almost give up but seeing how people are trying their best every day to solve the challenge so I left for a while to learn HTML & CSS again from scratch, so yesterday I decided to pick it up again to my surprise I did what I could not do then, although am not sure about every step I used if it the best practice but I am open to feedback. And a great thanks to those that comment last on my last project, they recommend great resources which I will go through all after I submit these. thanks a lot to this great community, whoever that have found it has helped 90% on my journey of learning to code...

    coding-bootcamp-testimonials-slider HTML, CSS & Javascript

    2
    Salko Balić•40
    @thedev966Posted over 3 years ago

    It's always easy to give up but whenever you feel like losing your motivation to keep it up, always do recall the reason why you even started this programming journey! Life is not meant to be easy, it's full of challenges you have to pass or just give up like a coward xd.

    Something you can improve:

    1. Your footer has an ugly transition on hover event. Use transition css property to fix it.
    2. css and js folders should not be inside of assets folder. Place them in the root directory
    3. You have uploaded styleguide file, design folder and screenshots folder for no reason to your github repo. Remove them.
    4. (Optional) Look up "BEM - Naming convention" and try to use it in your next project. It's the best way (imo) to name your css classes and keep it as clean as possible.
    0