Skip to content
OverviewSolutions
10
Comments
2
Alexandra Tarasova
@tasandra

All comments

  • Marcos Freire•110
    @mfreire1996Submitted over 1 year ago

    First time doing a challenge for Frontendmentor and it was quite an enjoyable journey. The difficult part for me was getting my javascript to work how I would normally do for my css. It still has some flaws in it such as when the user clicks submit and dismiss message the container now gets all squished even with the media queries. If anyone can tell me some better practices for my javascript that would be truly helpful. Thank you

    Newsletter challenge

    1
    Alexandra Tarasova•220
    @tasandraPosted over 1 year ago

    Hi, nice job. Everything aligns perfectly. I think the problem with dismiss button is you have container display: grid is css, but in javascript when the user click on dismiss button you assign it to display: block

    Marked as helpful
    1
  • Alexandra Tarasova•220
    @tasandraPosted over 1 year ago

    Nice work 😁! I like the coloring! Try to remove width from your HTML, it should center the card in a small screen

    <div class="card" style="width: 20rem;">
    0